Made the snap point disappear immediately upon releasing the activation key #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior state: when releasing the 'V' key, the yellow circle would only disappear after the mouse moved. New state: when releasing the 'V' key, the yellow circle immediately disappears. Also factored out the name of the key used to activate the plugin, to make it more obvious how to change it if needed.
|
This PR involves a little bit of refactoring which I think is beneficial to the code. Happy to drop any changes you deem not necessary. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this change, releasing the activation key ('v') would deactivate the addon without any visual feedback: the yellow snap point would only disappear after moving the mouse. This PR fixes this minor issue.