feat(types): Add type definition for default constructor in IJestHasteMap #14612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eMap This commit adds a type definition for the default constructor in the IJestHasteMap interface. Now, the type system will recognize the default constructor as a new instance of IHasteMap, allowing for more accurate type checking and improved code assistance. Changes Made: - Added 'default' property to the IJestHasteMap interface with type (new (options: Options) => IHasteMap).
✅ Deploy Preview for jestjs ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
SimenB
reviewed
Oct 11, 2023
packages/jest-haste-map/src/index.ts
Outdated
| }; | ||
|
|
||
| // @ts-expect-error(property `default is missing in HasteMap class`) |
There was a problem hiding this comment.
Can we cast instead or something? Adding type safety followed by a @ts-ignore seems unfortunate 😅
SimenB
approved these changes
Oct 11, 2023
|
ping @SimenB |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This commit adds a type definition for the default constructor in the
IJestHasteMapinterface. Now, the type system will recognize the default constructor as a new instance ofIHasteMap, allowing for more accurate type checking and improved code assistance.Before, when initializing a new HasteMap, the result was of type
any.After adding type definitions for default constructor, now the result have a type of
IHasteMap.This will result in improved developer experience while using
jest-haste-mappackage.Test plan
Before adding those type definitions, it looked like this :
and the resulting
maphad type ofanyafter adding type definitions , now it looks like this :
And the resulting
mapnow has the type ofIHasteMap