Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add eslint instructions to getting started #14562

Merged
merged 19 commits into from
Jan 16, 2024
Merged

Conversation

yepitschunked
Copy link
Contributor

Summary

ESLint is used in almost every project, but the docs don't talk about setting it up. This Stack Overflow question has 188k views: https://stackoverflow.com/questions/31629389/how-to-use-eslint-with-jest

The top answer links to docs from eslint-plugin-jest, when these instructions should just be part of Jest's docs.

Test plan

Docs change

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Sep 22, 2023

CLA Signed

The committers listed above are authorized under a signed CLA.

@netlify
Copy link

netlify bot commented Sep 22, 2023

Deploy Preview for jestjs ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 50ccff1
🔍 Latest deploy log https://app.netlify.com/sites/jestjs/deploys/65a6b9dd9d868a000886ff2b
😎 Deploy Preview https://deploy-preview-14562--jestjs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Can you add this to all versions of the docs?

docs/GettingStarted.md Outdated Show resolved Hide resolved
Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@SimenB SimenB enabled auto-merge (squash) October 3, 2023 17:43
auto-merge was automatically disabled October 6, 2023 18:22

Head branch was pushed to by a user without write access

@yepitschunked yepitschunked requested a review from SimenB October 13, 2023 23:45
@yepitschunked
Copy link
Contributor Author

@SimenB I had to fix some issues with prettier, it seems like automerge got disabled as a result - can you take another look?

docs/GettingStarted.md Outdated Show resolved Hide resolved
Copy link

This PR is stale because it has been open 90 days with no activity. Remove stale label or comment or this will be closed in 30 days.

@github-actions github-actions bot added the Stale label Jan 16, 2024
Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@SimenB SimenB enabled auto-merge (squash) January 16, 2024 17:17
@SimenB SimenB merged commit 7239acf into jestjs:main Jan 16, 2024
73 checks passed
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants