Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dark mode fixes #714

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Dark mode fixes #714

wants to merge 2 commits into from

Conversation

FinalDoom
Copy link
Contributor

@FinalDoom FinalDoom commented Jan 2, 2024

Make login, connection interrupted, and loading screens not blaringly white when dark mode is preferred/selected.

Description

  • Used modal colors from torrent location setting modal to add dark mode colors to Panel
  • Used similar colors to change backgrounds, text, etc. on relevant components.
  • Removed theme parameter from Panel as it was not used and unnecessarily specified light by default
  • Add inverse class where necessary to affect input coloring

Screenshots

Light Mode / Previous always

image image image

Dark Mode

image

Neat thing on this above one, there's actually blue sliders on the loading hamburger that you basically can't see in light mode because of the brightness blowout, but the lower contrast in dark makes them visible. (Fun human vision stuff)

image image

Types of changes

  • Breaking change (changes that break backward compatibility of public API or CLI - semver MAJOR)
  • New feature (non-breaking change which adds functionality - semver MINOR)
  • Bug fix (non-breaking change which fixes an issue - semver PATCH)

Copy link

codecov bot commented Jan 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (748195a) 73.14% compared to head (92126e4) 73.14%.

❗ Current head 92126e4 differs from pull request most recent head 470aca6. Consider uploading reports for the commit 470aca6 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #714   +/-   ##
=======================================
  Coverage   73.14%   73.14%           
=======================================
  Files          62       62           
  Lines       11375    11375           
  Branches      962      958    -4     
=======================================
  Hits         8320     8320           
  Misses       3041     3041           
  Partials       14       14           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@trim21
Copy link
Collaborator

trim21 commented Jan 7, 2024

can you paste some screenshots about this fix?

@FinalDoom
Copy link
Contributor Author

can you paste some screenshots about this fix?

Updated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants