Fix torrent download extension override #539
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Firefox bug was fixed in version 87.
The API data handler streaming feature is now opt-in, and controls whether the file type is overridden.
|
This is another Firefox bug, which shall be reported to them. The extension declared by Meanwhile, we can use the User Agent condition for this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When downloading a single mkv file, Flood is changing its content-type to webm, and it makes Firefox change the file extension to .webm, which is annoying.
This PR fixes that by making the content-type override opt-in and only enabled in the file preview links.
I'd also like to add direct download links to the torrent files modal, next to the clipboard icon (or the reverse, make the file link a download and add a preview button). This would be useful when a torrent contains a few files that can be downloaded manually instead of going through the tar export. What do you think ?
Types of changes