Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix double quote parsing error #332

Merged
merged 5 commits into from
Aug 19, 2024
Merged

Conversation

scootermon
Copy link
Contributor

@scootermon scootermon commented Aug 16, 2024

indexOf returns -1 when not found, which is a truthy value. This results in quotes getting stripped from every single line, which then causes an issue if the previously quoted string contained a colon.

Fixes #326

@jens-maus
Copy link
Owner

Please add test cases accordingly to get this PR accepted/integrated..

@jens-maus
Copy link
Owner

Thanks for integrating a test unit for this PR! However, what about using the exact ics string from the corresponding issue #326 in your unit test? IMHO it would be more precise to use the exact same ics to verify that #326 is really fixed.

@scootermon
Copy link
Contributor Author

That's fair, I updated the test to match the example provided in the issue.

@jens-maus jens-maus merged commit 8b0f559 into jens-maus:master Aug 19, 2024
15 checks passed
50an6xy06r6n added a commit to 50an6xy06r6n/node-ical that referenced this pull request Aug 27, 2024
A different test22.ics has been added as part of jens-maus#332
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect parsing of quoted string parameters in attendee
2 participants