#313 Add unknown Tyoe #327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hehe, same as #317 just different ... soooo @jens-maus any or unknown your decision gg |
Sorry, I am not an TS expert.. So what are the implications of any vs. unknown here? |
|
Hello Jens, 'Any' turns off type checking completely, thus increasing risks for bugs at usages, while 'unknown' enforces the developer to implement his own type checks (typeof) or cast's (as ...). So in this case unknown is more stable until we add a specific definition/interface for those objects. This might be an interesting article about the topic with some examples: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.