[JENKINS-66326] Prepare SCM Sync Configuration for core Guava upgrade #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@guipal @rodrigc Gentle ping. It would be nice to get this PR merged and released to facilitate the upcoming Guava upgrade in Jenkins core (JEP-233). |
johnou
approved these changes
May 7, 2022
preddymm
approved these changes
May 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Downstream of #70. See JENKINS-66326 and JENKINS-65988. Jenkins core is using Guava 11.0.1, which was released on January 9, 2012. Jenkins core would like to upgrade to Guava 30.1.1, which was released on March 19, 2021. Plugins must be prepared to be compatible with both Guava 11.0.1 and Guava 30.1.1 in advance of this core transition.
In particular, this plugin has been identified as using the following methods which have been removed in the latest version of Guava:
com/google/common/io/ByteStreams#getChecksumcom/google/common/io/ByteStreams#newInputStreamSuppliercom/google/common/io/Files#getChecksumThese methods existed in Guava 11.0.1 but have been removed in recent versions.
To facilitate the Jenkins core transition, this plugin must be prepared and released such that it works with both Guava 11.0.1 and latest. This PR rewrites the relevant code to avoid the use of Guava and use native Java Platform functionality instead.
CC @guipal @rodrigc