Merge pull request #192 from mawinter69/security

revert change to Role

src/main/java/com/michelin/cio/hudson/plugins/rolestrategy/Role.java

@@ -42,7 +42,7 @@
  * Class representing a role, which holds a set of {@link Permission}s.
  * @author Thomas Maurel
  */
-public final class Role implements Comparable<Role> {
+public final class Role implements Comparable {
   public static final String GLOBAL_ROLE_PATTERN = ".*";
 
   private static final Logger LOGGER = Logger.getLogger(Role.class.getName());
@@ -177,10 +177,14 @@ public Boolean hasAnyPermission(Set<Permission> permissions) {
    * @return Comparison of role names
    */
   @Override
-  public int compareTo(@NonNull Role o) {
+  public int compareTo(@NonNull Object o) {
     Objects.requireNonNull(o);
-
-    return name.compareTo(((Role)o).name);
+
+    if (o instanceof Role) {
+      return name.compareTo(((Role)o).name);
+    }
+
+    return -1;
   }
 
     @Override