-
-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[JENKINS-73339] Require Java 17 and Jetty 12 (EE 9) for plugin development #1004
Conversation
pom.xml
Outdated
<incrementals-enforce-minimum.version>1.0-beta-4</incrementals-enforce-minimum.version> | ||
<incrementals-plugin.version>1.8</incrementals-plugin.version> | ||
<jacoco-maven-plugin.version>0.8.12</jacoco-maven-plugin.version> | ||
<jenkins.version>2.361</jenkins.version> | ||
<jenkins.version>2.476</jenkins.version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Currently using 2.476 in this PR as a placeholder, but planning to update this to whatever is selected as the next LTS line.
pom.xml
Outdated
<jenkins-bom.version>${jenkins.version}</jenkins-bom.version> | ||
<jenkins-test-harness.version>2225.2230.v6210cb_b_827f9</jenkins-test-harness.version> | ||
<jenkins-test-harness.version>2272.v5db_817b_a_6f0d</jenkins-test-harness.version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Requires Java 17 or newer and Jetty 12 (EE 9) or newer.
@@ -74,13 +74,13 @@ | |||
<frontend-version>1.15.0</frontend-version> | |||
<gmavenplus-plugin.version>3.0.2</gmavenplus-plugin.version> | |||
<hamcrest.version>3.0</hamcrest.version> | |||
<hpi-plugin.version>3.57</hpi-plugin.version> | |||
<hpi-plugin.version>3.58</hpi-plugin.version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Requires Java 17 or newer and Jetty 12 (EE 9) or newer.
de84494
to
6d412be
Compare
6d412be
to
ccfbc39
Compare
Moving this out of draft since 2.477 appears to be on track for LTS selection and I just performed a release of this repository. We could merge this now and then just wait about a month to release it until 2.477.1 is released. I have no strong preference, though, so if we want to wait to merge this PR, that is fine with me as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems useful to merge & release now, for the benefit of plugins which were obliged to switch to a 2.477 baseline for whatever reason.
Thanks for release @timja! |
|
||
In the long term, this ought to be mitigated by removing ASM from Jenkins core. | ||
--> | ||
<exclude>org.ow2.asm:asm</exclude> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Causes #1032 for reasons I do not (yet) understand.
In draft until EE 9 is delivered in an LTS release.
Testing done
mvn clean verify
Fixes #936
Fixes #918