[FIXED JENKINS-43857] Mask Secret parameters in InputSubmittedAction #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation. |
jglick
requested changes
Apr 26, 2017
| @@ -122,7 +122,10 @@ public void parameter() throws Exception { | |||
|
|
|||
| // make sure 'x' gets assigned to false | |||
| System.out.println(b.getLog()); | |||
| assertTrue(b.getLog().contains("after: false")); | |||
| // TODO: Should we be masking Secrets? | |||
There was a problem hiding this comment.
Well yes, that is the important problem to solve!
| String k = entry.getKey(); | ||
| Object v = entry.getValue(); | ||
| if (v instanceof Secret) { | ||
| this.parameters.put(k, "******"); |
There was a problem hiding this comment.
Why? The plaintext cannot be recovered from build.xml without access to global keys anyway. PasswordParameterValue stores a Secret so why should we not do the same here?
|
I'll let @i386 comment since this was his concern. |
|
Problem: If we serialize the contents of this Action via Staplers export mechanism then would we be leaking secrets? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JENKINS-43857
cc @reviewbybees