Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow customization of Job icons #9723

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

strangelookingnerd
Copy link
Contributor

@strangelookingnerd strangelookingnerd commented Sep 12, 2024

In a discussion with @jonesbusy in jenkinsci/custom-folder-icon-plugin#387 I stumbled upon custom-job-icon-plugin which by now has become deprecated / out-dated but brought up the interesting idea of being able to change the default icon of a Job from the BallColor to something else similar as custom-folder-icon-plugin already does it for AbstractFolder.

Since I really liked the idea and already have a use case myself I wanted to bring this to the core to lay the foundation.
Once this is done I'd like to adopt the custom-job-icon-plugin and build up on it.

This PR introduces the icon field of type JobIcon to a Job. It is used in the relevant *.jelly files of the core to visualize a Job and by default relies on a new implementation BuildStatusIcon.
A Job now has a configuration for its icon. Overall the implementation is very similar to the approach of cloudbees-folder-plugin.

Screenshots:

Main View
grafik

Job Overview
grafik

Configuration
grafik

Full disclaimer, I am aware that this draft is still a little rough on the edges how ever to see if this goes anywhere I'd be grateful for some feedback.

Testing done

Only manual testing so far, tests to follow in case we want to follow up on this draft.
For testing purposes I also included the TestIcon class to have something to work with other than the default.

Proposed changelog entries

  • Allow customization of Job icons

Proposed upgrade guidelines

N/A

Submitter checklist

Desired reviewers

N/A

Before the changes are marked as ready-for-merge:

Maintainer checklist

@jonesbusy
Copy link
Contributor

Thanks! I really like the idea!

@timja timja added rfe For changelog: Minor enhancement. use `major-rfe` for changes to be highlighted web-ui The PR includes WebUI changes which may need special expertise labels Sep 13, 2024
@timja timja requested a review from a team September 13, 2024 08:26
@strangelookingnerd strangelookingnerd force-pushed the feature/configurable_job_icon branch 2 times, most recently from 541cda9 to 6cfa2a5 Compare September 17, 2024 14:43
@strangelookingnerd strangelookingnerd marked this pull request as ready for review September 17, 2024 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rfe For changelog: Minor enhancement. use `major-rfe` for changes to be highlighted web-ui The PR includes WebUI changes which may need special expertise
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants