Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix potential github action smells #9236

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ceddy4395
Copy link

@ceddy4395 ceddy4395 commented May 5, 2024

Hey! 🙂
I want to contribute the following changes to your workflow:

  • Define permissions for workflows with external actions
  • Avoid starting new workflow whilst the previous one is still running
  • Avoid deploying jobs on forks

(These changes are part of a research Study at TU Delft looking at GitHub Action Smells. Find out more)

Testing done

None

Proposed changelog entries

  • N/A

Proposed upgrade guidelines

N/A

Submitter checklist

Desired reviewers

N/A

Before the changes are marked as ready-for-merge:

Maintainer checklist

- Define permissions for workflows with external actions
- Avoid starting new workflow whilst the previous one is still running
- Avoid deploying jobs on forks
Copy link

welcome bot commented May 5, 2024

Yay, your first pull request towards Jenkins core was created successfully! Thank you so much!

A contributor will provide feedback soon. Meanwhile, you can join the chats and community forums to connect with other Jenkins users, developers, and maintainers.

@ceddy4395 ceddy4395 changed the title Fix gha smells: Fix potential github action smells May 5, 2024
@MarkEWaite MarkEWaite added the skip-changelog Should not be shown in the changelog label May 6, 2024
Copy link
Contributor

@MarkEWaite MarkEWaite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a question on the concurrency limiting change in the upload-release action. If an upload is interrupted, will the partial upload be discarded or retained?

The checks for repository are a positive change that I fully support.

.github/workflows/publish-release-artifact.yml Outdated Show resolved Hide resolved
Remove concurrency to avoid interrupting uploads.

Co-authored-by: Mark Waite <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-changelog Should not be shown in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants