Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JENKINS-46081: Add MessageExclusion trait #727

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

JENKINS-46081: Add MessageExclusion trait #727

wants to merge 6 commits into from

Conversation

chriskilding
Copy link

@chriskilding chriskilding commented Jun 28, 2019 •
edited
Loading

JENKINS-46081 - Add MessageExclusion trait

Add a corresponding trait for the MessageExclusion extension.

Checklist

  • I have read the CONTRIBUTING doc
  • I have referenced the Jira issue related to my changes in one or more commit messages
  • I have added tests that verify my changes
  • Unit tests pass locally with my changes
  • No Javadoc warnings were introduced with my changes
  • No spotbugs warnings were introduced with my changes
  • I have interactively tested my changes

Types of changes

  • New feature (non-breaking change which adds functionality)

Further comments

I have tried to test this interactively by running a noddy multibranch pipeline job with an example Jenkinsfile, but I’m not sure that the MessageExclusion itself actually works.

@chriskilding chriskilding changed the title Feature/message exclusion trait JENKINS-46081: Add MessageExclusion trait Jun 28, 2019
@MarkEWaite MarkEWaite added the enhancement Improvement or new feature label Jul 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarkEWaite MarkEWaite MarkEWaite left review comments

Assignees
No one assigned
Labels
enhancement Improvement or new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chriskilding @MarkEWaite