Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Git ssh private key binding(GSoC-21) #1111
base: master
Are you sure you want to change the base?
Git ssh private key binding(GSoC-21) #1111
Changes from 70 commits
e9c550a
4fd5c4c
e212567
78a47fb
818599a
6eeecee
2bc3140
e45ed33
9030a2c
9312a70
a8f38f3
9e17779
b53385b
588c389
d70831c
443c0f7
65624c0
a55e3dd
d38eea0
f57be59
df3d33c
0996235
47588ae
7549c54
d1eeb22
96c0103
d3ee23a
c218b0b
d596240
8922ada
a44b388
a42ac94
598eb80
5c47934
752a94a
035e6c2
dcba7c9
fbba6f9
69fafe5
ee925a7
4a5e7de
63680a0
8c525eb
4ec3a3d
638989b
e830aef
be399fb
73b01ba
7ef7820
b419b4c
9bc6d3a
82022ef
3f82b61
30064ed
319442e
ea86cda
dcc83b3
29cdcd7
e13d669
dc83e1c
583ee18
cbf6215
74500c1
1ff2fcb
fc81ba3
c6d9b3b
607a5ab
1662e96
c0d14aa
99535a8
85dfeed
d7f3b55
2efc015
e9d572d
be8b2e9
a98514f
649cd85
1766ec2
74b4f16
f168ecb
71bd8fb
b6eebfd
b6eeac2
66009a8
06c8073
187b399
e12419b
828cc94
dd86551
cdefb57
1ce0079
0e5b9fb
1354b1f
eefb41d
83171e3
3a238c0
c63559c
4654472
b3b2f69
8396478
b097fb5
0a40c33
1785381
78651ae
825eda8
4a5fbdf
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Optional: For better maintainability, personally I would recommend using
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice suggestion, will check this out.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
...
-o StrictHostKeyChecking=no"
...This seems to go against the https://github.com/jenkinsci/git-client-plugin#ssh-host-key-verification feature.
@MarkEWaite is that correct?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed @sboardwell . This needs to be extended to support the host key checking strategy before it is merged.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the same reason, I think whenever a string is getting complex, it should be formatted using a String.format().
Check warning
Code scanning / Jenkins Security Scan
Stapler: Missing permission check
Check warning
Code scanning / Jenkins Security Scan
Jenkins: Plaintext password storage
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are we passing null values? If these arguments are not needed and are optional then why are we asking them here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The caller function of writePrivateKeyOpenSSHFormatted is already throwing these exceptions, what is the reason of catching them here? Also should we not use the logger function to log the reason of error instead of dumping the whole stack trace?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You may use .concat() function instead of the + operator.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
are all constants that mean compile-time this will be replaced with its calculate valued, with concat it should remain a function called every time. When concat constants I think better + operator.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
instead you could move HEADER definition as constant and use here and in getEncData function