-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(updatecli) tracks aws load balancer
helm release version
#104
base: main
Are you sure you want to change the base?
chore(updatecli) tracks aws load balancer
helm release version
#104
Conversation
Signed-off-by: jayfranco999 <[email protected]>
Signed-off-by: jayfranco999 <[email protected]>
Signed-off-by: jayfranco999 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code looks good, except for the updatecli source which does not track the correct version (see my inline comment).
Merging this PR won't break the infra, but it will raise an automatic PR which request us to bump from 1.11.0 to 2.x.y the chart version which is suspicious (and won't work) ;)
lastChartVersion: | ||
name: aws-load-balancer-controller Helm Chart Latest Version | ||
kind: githubrelease | ||
spec: | ||
owner: kubernetes-sigs | ||
repository: aws-load-balancer-controller | ||
token: "{{ requiredEnv .github.token }}" | ||
username: "{{ .github.username }}" | ||
versionFilter: | ||
kind: latest | ||
transformers: | ||
- trimprefix: "v" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not the correct source. https://github.com/kubernetes-sigs/aws-load-balancer-controller hosts the Golang code for the Controller itself, so the releases such as https://github.com/kubernetes-sigs/aws-load-balancer-controller/releases/tag/v2.11.0 only point to a Docker image.
If you look at the Terraform code targeted by the Updatecli target, it tracks an Helm Chart named aws-load-balancer-controller
hosted in the Helm Repository at https://aws.github.io/eks-charts (you can find more informations about Helm repository in https://helm.sh/docs/topics/chart_repository/ if needed).
=> Good news, Updatecli supports native sources for Helm Chart to retrieve the version (as documented in https://www.updatecli.io/docs/plugins/resource/helm_chart/).
You can look at one of our existing manifests tracking helm charts in https://github.com/jenkins-infra/kubernetes-management/blob/fe01e42d1300e8ebd293eeef1c30c361e8b77614/updatecli/updatecli.d/charts/datadog.yaml#L16-L21
As per jenkins-infra/helpdesk#4503
This pr tracks
aws load balancer
helm release version using github release as source,Tested locally with success: