chore(updatecli) tracks karpenter helm release version

[jayfranco999]

As per jenkins-infra/helpdesk#4504

This PR tracks terraform aws module karpenter helm release version by using github-release as source

Tested locally with success:

TARGETS
========

updateChartVersion
------------------

**Dry Run enabled**

✔ - no changes detected:
        path "resource.helm_release.karpenter.version" already set to "1.1.1", from file "eks-cijenkinsio-agents-2.tf", 

[dduportal]

Same as https://github.com/jenkins-infra/terraform-aws-sponsorship/pull/104/files/def043a6c343e7479b42a3431d31186eb2014a9b#r1923504399 (you want the source to track an Helm chart, not a github release)

[dduportal]

Code looks good, except for the source (same as https://github.com/jenkins-infra/terraform-aws-sponsorship/pull/104/files/def043a6c343e7479b42a3431d31186eb2014a9b#r1923504399)

[jayfranco999]

Update:

Unable to access the ECR repository helm chart

ERROR: ✗ unable to list versions for OCI Helm chart public.ecr.aws/karpenter/karpenter: error getting credentials - err: signal: killed, out: ``

[dduportal]

Update:

Unable to access the ECR repository helm chart

ERROR: ✗ unable to list versions for OCI Helm chart public.ecr.aws/karpenter/karpenter: error getting credentials - err: signal: killed, out: ``

Oh I forgot I had this issue on my local machine: https://karpenter.sh/docs/getting-started/getting-started-with-karpenter/#4-install-karpenter states a logout is required (to ensure there are no credentials):

# Logout of helm registry to perform an unauthenticated pull against the public ECR
helm registry logout public.ecr.aws

This will be a tricky one: in order to run the logout command in a pipeline sh step just before the updatecli command, we'll have to rework the updatecli pipeline library.
As you can see in https://github.com/jenkins-infra/pipeline-library/blob/a8f4890ea296bf331246d6ce2d40c59b514883e0/vars/updatecli.groovy#L53, the updatecli command is executed inside a node() block command (https://github.com/jenkins-infra/pipeline-library/blob/a8f4890ea296bf331246d6ce2d40c59b514883e0/vars/updatecli.groovy#L32-L58).

It means we have no way to inject, today, any command: if you change the Jenkinsfile_updatecli calling pipeline, you won't be able to access the updatecli() pipeline library function's context.

Additionally, it might be an issue in updatecli CLI itself in the way it requests the helm charts: do you have the same issue on your machine?

[jayfranco999]

Yes I have the same issue while running locally.

[dduportal]

Yes I have the same issue while running locally.

Then, it's worth opening an issue on updatecli as we're blocked by this

[jayfranco999]

Update:

We now use helm chart source to retrieve the latest helm release:

Tested successfully on infra.ci (https://infra.ci.jenkins.io/job/updatecli/job/terraform-aws-sponsorship/job/PR-103/18/pipeline-console/log?nodeId=18)

[2025-02-11T09:55:13.655Z] target: target#updateChartVersion
[2025-02-11T09:55:13.655Z] -------------------------
[2025-02-11T09:55:13.655Z] 
[2025-02-11T09:55:13.655Z] **Dry Run enabled**
[2025-02-11T09:55:13.655Z] 
[2025-02-11T09:55:13.655Z] ⚠ - changes detected:
[2025-02-11T09:55:13.655Z] 	path "resource.helm_release.cijenkinsio_agents_2_karpenter.version" updated from "1.1.1" to "1.2.1" in file "eks-cijenkinsio-agents-2.tf"

Noticed an unexpected behaviour on updatecli pipeline where jobs were failing since manifest to fetch aws provider version was failing (unrelated to PR but worth looking into)

[2025-02-11T09:55:13.656Z] ERROR: something went wrong in "target#updateTerraformLockFile" : something went wrong in target "updateTerraformLockFile" : "✗ failed to query provider locks for provider: \"hashicorp/aws\", version: \"5.86.1\", platforms: [\"linux_amd64\" \"linux_arm64\" \"darwin_amd64\" \"darwin_arm64\"]: unexpected HTTP Status Code: 404"
[2025-02-11T09:55:13.656Z] 
[2025-02-11T09:55:13.656Z] Pipeline "Bump Terraform `aws` provider version" failed
[2025-02-11T09:55:13.656Z] Skipping due to:
[2025-02-11T09:55:13.656Z] 	something went wrong during target execution

[dduportal]

Great job! LGTM

[dduportal]

Merging as:

• The failing updatecli check is unrelated (it also is present on the main branch)
• The updatecli check maps to the tests run by @jayfranco999:

[2025-02-11T10:39:44.052Z] ⚠ - changes detected:
[2025-02-11T10:39:44.052Z] 	path "resource.helm_release.cijenkinsio_agents_2_karpenter.version" updated from "1.1.1" to "1.2.1" in file "eks-cijenkinsio-agents-2.tf"

LGTM