Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add contributors.jenkins.io #97

Merged
merged 2 commits into from
Nov 27, 2023
Merged

feat: add contributors.jenkins.io #97

merged 2 commits into from
Nov 27, 2023

Conversation

lemeurherve
Copy link
Member

@lemeurherve lemeurherve requested review from dduportal, smerle33 and a team November 23, 2023 17:39
dduportal
dduportal requested changes Nov 24, 2023
View reviewed changes
Copy link
Contributor

@dduportal dduportal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work. A set of blocking change due to copy and paste typo, but otherwise it looks good

services.tf Outdated Show resolved Hide resolved
@lemeurherve @dduportal
Update services.tf
c5129a5 
Co-authored-by: Damien Duportal <[email protected]>
@lemeurherve lemeurherve merged commit cebd72f into jenkins-infra:main Nov 27, 2023
1 check passed
@lemeurherve lemeurherve deleted the helpdesk3809-add-contributors-jenkins-io branch November 27, 2023 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dduportal dduportal dduportal approved these changes

@smerle33 smerle33 Awaiting requested review from smerle33

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lemeurherve @dduportal