feat: add contributorsjenkinsio storage account
#523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lemeurherve
changed the title
contributors storage accountcontributorsjenkinsio storage account
|
|
New resources for a service not yet in production, self-merging to continue on the subject. |
lemeurherve
added a commit
that referenced
this pull request
Nov 23, 2023
This PR adds the File Share that will be used by the nginx-website release on publick8s cluster to serve on contributors.origin.jenkins.io the content generated in https://github.com/jenkins-infra/contributor-spotlight/. It also rename the storage account resource to be uniform. Follow-up of #523 Ref: - jenkins-infra/helpdesk#3809 (comment)
dduportal
reviewed
Nov 23, 2023
| resource_group_name = azurerm_resource_group.contributors_jenkins_io.name | ||
| location = azurerm_resource_group.contributors_jenkins_io.location | ||
| account_tier = "Standard" | ||
| account_replication_type = "GRS" |
There was a problem hiding this comment.
What is the reasoning behind using GRS here? (vs. LRS or ZRS) . Could you explain it in the issue (and the eventual cost impact)
lemeurherve
added a commit
that referenced
this pull request
Nov 27, 2023
…re (#528) This PR recreates the storage account and the file share for contributors.jenkins.io The network rules deleted in a hotfix commit were still present when looking at the storage account in Azure Portal. I've deleted the (empty) storage account to recreate it with this PR. Other changes: - ZRS: no need for GRS, ZRS is sufficient - Type StorageV2: default value from the terraform provider, "Storage" (v1) is the legacy one, no cost change between them. - Add back network rules, allowing our IPs and the ones from publick8s and privatek8s vnets. Follow-up of: - #523 - #524 Ref: - jenkins-infra/helpdesk#3809 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR creates a resource group and a storage account to store the static HTML content generated by jenkins-infra/contributor-spotlight#15 and which will be mounted as volume to be served on contributors.origin.jenkins.io from
publick8scluster. (contributors.jenkins.io will be served by the CDN Fastly)This content doesn't need to be accessible from elsewhere, hence the network protection.
Ref: