Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add abortable fetch polyfill #4973

Merged
merged 1 commit into from
Nov 9, 2023
Merged

Conversation

dmitrylyzo
Copy link
Contributor

AbortController is not enough (#4958).

Changes
Add abortable fetch polyfill.

Issues
Fixes #4940

AbortController is not enough (e7d00d7).
@dmitrylyzo dmitrylyzo added bug Something isn't working regression We broke something labels Nov 9, 2023
@dmitrylyzo dmitrylyzo requested a review from a team as a code owner November 9, 2023 22:14
Copy link

sonarqubecloud bot commented Nov 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
1.0% 1.0% Duplication

@dmitrylyzo dmitrylyzo added this to the v10.9.0 milestone Nov 9, 2023
@jellyfin-bot
Copy link
Collaborator

Cloudflare Pages deployment

Latest commit d98af47
Status ✅ Deployed!
Preview URL https://a31266e8.jellyfin-web.pages.dev
Type 🔀 Preview

View build logs
View bot logs

@thornbill thornbill merged commit cc0bc62 into jellyfin:master Nov 9, 2023
@dmitrylyzo dmitrylyzo deleted the fix-legacy2 branch November 9, 2023 23:07
@rafma0
Copy link
Contributor

rafma0 commented Nov 10, 2023

@dmitrylyzo sorry if I'm being annoying but it's still not working. I tried running the debug build in the 5.0 emulator, to see if it would show any messages on device manager, then I tried running it on tizen ide to see if I could debug the js but I couldn't make it launch. Where I'm at right now is I can insert the server ip, and it gets stuck on a screen with the clock on top.

image

@dmitrylyzo
Copy link
Contributor Author

I tested in Tizen 5 emulator too and it worked. 😕
But I usually test the development build.

Also, this may be due to a recent dependency update.

To run Tizen debug you need Chrome 79- (or 80- ?) and start debugging from the command line. See jellyfin/jellyfin-tizen#79

@rafma0
Copy link
Contributor

rafma0 commented Nov 10, 2023

Thank you for the link to the guide, I managed to make debug work with latest Chrome (119) opening chrome://inspect/#devices, in Discover network targets click Configure..., add tv-ip:debug-port, and in ~5 secs it shows as a new Remote Target. Then click inspect.

Here's the results after I put the ip and click Connect on the TV (same thing on the emulator)

image

I also deleted node_modules from jellyfin(web|tizen) and npm ci --no-audit again. I'm probably just too tired. I'll try again tomorrow :)

@dmitrylyzo
Copy link
Contributor Author

dmitrylyzo commented Nov 10, 2023

Yes, webOS 1.2 fails again. 😩

node_modules.core-js.bundle.js?bf36f1725aebd62b4fa5: Invalid flags supplied to RegExp constructor.

Reverting this PR fixes RegExp error.

Probably because marked started using the u flag (Unicode) for RegExp, which is not supported by older browsers.
Yes, tried removing u from the marked module in dist - it starts working.

@rafma0
Copy link
Contributor

rafma0 commented Nov 12, 2023

I'm not really experienced with webpack and babel but I tried a few things to see if I could change how marked and/or core-js are transpiled... and I didn't have any success 😆. The latest version of marked that seems to be working is 5.0.5. Not sure if we should set marked to this version and fixate it in renovate, or if there's a better simpler solution.

@dmitrylyzo
Copy link
Contributor Author

I'm not really experienced with webpack and babel

Me, too 😅
I tried @babel/plugin-transform-unicode-regex. But it doesn't transform RegExp('...', 'u').

@rafma0
Copy link
Contributor

rafma0 commented Nov 12, 2023

Another option would be replacing marked with markdown-it. This lib seems to be maintained and nearly as popular. I did some tests here https://github.com/rafma0/jellyfin-web/tree/replace-markdown-lib and it seems to work the same, and looks like the maintainer care about keeping compatibility with old browsers markdown-it/markdown-it#948 (comment), should I send a PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working regression We broke something
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Black screen on Tizen 5.0 (2019) after #35429ca
4 participants