perf(bundle): treeshake options API #2352
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cloudflare Pages deployment
|
ferferga
force-pushed
the
test-bundle-reduction
branch
from
331f581 to
ab77945
Compare
ferferga
force-pushed
the
master
branch
15 times, most recently
from
acb6ecf to
5d6a7c8
Compare
ferferga
force-pushed
the
master
branch
2 times, most recently
from
c360429 to
f3260d9
Compare
ferferga
force-pushed
the
master
branch
6 times, most recently
from
1196c3f to
22eff75
Compare
ferferga
force-pushed
the
test-bundle-reduction
branch
from
ab77945 to
9d8eb0b
Compare
ferferga
force-pushed
the
test-bundle-reduction
branch
from
9d8eb0b to
737860a
Compare
ferferga
force-pushed
the
test-bundle-reduction
branch
from
737860a to
148bcc7
Compare
ferferga
force-pushed
the
test-bundle-reduction
branch
from
148bcc7 to
b3a36e4
Compare
ferferga
force-pushed
the
test-bundle-reduction
branch
from
b3a36e4 to
97719cd
Compare
ferferga
force-pushed
the
master
branch
3 times, most recently
from
f9af7d1 to
b898fd1
Compare
ferferga
force-pushed
the
test-bundle-reduction
branch
from
97719cd to
5be0661
Compare
For some reason, the client throwed an error about incorrect attribute when using Docker buildx's docker-container driver. The build worked flawlessly when using the normal docker build command (which is now an alias to docker buildx build, but with the docker driver) and in the host system using normal commands, and that's why it went unnoticed. Really strange error... Perhaps something encoding related in the outputted files? Either way, this commit fixes it by removing the trailing double quotes from the component!
Signed-off-by: GitHub <[email protected]>
ferferga
force-pushed
the
test-bundle-reduction
branch
from
5be0661 to
2db9cfe
Compare
|
ferferga
force-pushed
the
master
branch
4 times, most recently
from
da410ff to
9a9eeae
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reduces bundle size and perhaps (not measured) improves performance by not having the unnecessary abstractions of Options API:
Checklist
defineOptionsthat might have been added after this description has been written.