Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Meta] Re-Organize Admin Dashboard #1401

Merged
merged 71 commits into from
Jan 23, 2025
Merged

Conversation

JPKribs
Copy link
Member

@JPKribs JPKribs commented Jan 20, 2025

Summary

Now that we're all wrapped up on Admin Dashboard (until 10.10), I wanted to group this a little better to be less chaotic. Groups the Admin Dashboard items into folders by function. Now looks like this:

New:
Screenshot 2025-01-20 at 14 59 38

Previous:
Screenshot 2025-01-20 at 15 03 06

- Upload image isn't working
- Only a single image is shown per section. Need to make this the HCollection of all images for the group
… because I think that's better. Spacing on the add screen is still all wrong but we're getting closer
TODO:

- Spacing for remote portrait images is wrong & cramped
- Upload image from file browser never works & produces 400 error
- Show all images for an item.imageType opposed to just the first
- Setting image works but produces a 400 error
- Error alert looks bad
Selecting a Remote image is now working without error and works consistently!

Upload a local file is still broken

Item types with multiple images is working as intended now!

Overriding an image on index doesn't seem to work but it doesn't work for Web either so........

UI is way more jank but the hard parts are getting solved!
Copy link
Member

@LePips LePips left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're fine since we squash PR commits but I would recommend not re-using branches.

@LePips LePips merged commit 757ea4d into jellyfin:main Jan 23, 2025
4 checks passed
@JPKribs JPKribs deleted the editItemImages branch January 23, 2025 04:19
@JPKribs JPKribs added enhancement New feature or request developer Developer facing issues labels Jan 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
developer Developer facing issues enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants