-
-
Notifications
You must be signed in to change notification settings - Fork 306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Meta] Re-Organize Admin Dashboard #1401
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Upload image isn't working - Only a single image is shown per section. Need to make this the HCollection of all images for the group
… because I think that's better. Spacing on the add screen is still all wrong but we're getting closer
TODO: - Spacing for remote portrait images is wrong & cramped - Upload image from file browser never works & produces 400 error - Show all images for an item.imageType opposed to just the first - Setting image works but produces a 400 error - Error alert looks bad
Selecting a Remote image is now working without error and works consistently! Upload a local file is still broken Item types with multiple images is working as intended now! Overriding an image on index doesn't seem to work but it doesn't work for Web either so........ UI is way more jank but the hard parts are getting solved!
…into editItemImages
…ere, fix it there.
…into jpkribs/editItemImages
LePips
approved these changes
Jan 23, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're fine since we squash PR commits but I would recommend not re-using branches.
JPKribs
added
enhancement
New feature or request
developer
Developer facing issues
labels
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Now that we're all wrapped up on Admin Dashboard (until 10.10), I wanted to group this a little better to be less chaotic. Groups the Admin Dashboard items into folders by function. Now looks like this:
New:
Previous: