Move to IdentifiedArray in PagingLibraryViewModel
#1346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JPKribs
approved these changes
Dec 8, 2024
There was a problem hiding this comment.
I took a look through and it looks good. Tested it locally and everything seems to be working as expected.
My only note is on the runtime labels which isn't really related to this PR but just makes the commit history a little weird moving runtime up and down 3 lines.
JPKribs
added
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As laid out in #1339, we need to move to
IdentifiedArraywhere applicable. This starts withPagingLibraryViewModel, probably the most important target of the issue.I largely refactored my
CollectionHStackandCollectionVGridpackages to no longer depend onOrderedSet, mirroringList, and fixed all instances accordingly.