[iOS] Fix #1256

[Gondnat]

This PR is used to fix "Can't select subtitles, it jumps back to none #1256"

There are two parts to fix it:

1. The SubtitleProfile in request should be as below, the old profile will get broken DeliveryUrl for external subtitles.

{Format: "vtt", Method: "External"}

The broken URL lost the extension name ".vtt" after Stream.

Borken URL

"DeliveryUrl": "/Videos/7c4730fd-90f1-e75e-656c-fe7da8fb22aa/7c4730fd90f1e75e656cfe7da8fb22aa/Subtitles/0/0/Stream?api_key=953dccded7e2455ba0088f62cf322dfc",

Normal URL

"DeliveryUrl": "/Videos/7c4730fd-90f1-e75e-656c-fe7da8fb22aa/7c4730fd90f1e75e656cfe7da8fb22aa/Subtitles/0/0/Stream.vtt?api_key=953dccded7e2455ba0088f62cf322dfc",

2. To make embedded subtitles work well, they should reduce as same as embedded audio in function adjustAudioForExternalSubtitles

[LePips]

Apologies for the long wait, I know this is a somewhat simple fix but so was #1219 and that didn't entirely fix the issue. There are a few edge cases for me to consider, mainly with transcoded streams + external subtitles, that I remember being wacky that may contribute to this issue that I will need to test with.

[JPKribs]

Hey all! I just had a chance to test this and unfortunately this does not appear to fully resolve the issue. On DirectPlay, external subtitles work correctly. When transcoding, this the issue is still persistent for external subtitles.

[JPKribs]

I've been screwing around with this for a bit. Does Jellyfin/Swiftfin downsample audio? I think our Transcode Subtitle Index is getting thrown off because the audio index is unreliable. It looks like the Audio selection also gets screwed up by being transcoded but it seems to be more likely to get screwed up with multiple audio/subtitle sources.

From testing, this PR seems to work very consistently with non-transcoded content. IMO, maybe we pas in the StreamType as a parameter then have this run for DirectPlay. Figuring out transcoded should still be part of the solution but this would be my take on this:

func adjustExternalSubtitleIndexes(streamType: StreamType, audioStreamCount: Int) -> [MediaStream] {
    guard allSatisfy({ $0.type == .subtitle }) else { return self }
    
    let embeddedSubtitleCount = filter { !($0.isExternal ?? false) }.count
    let externalSubtitleCount = filter { $0.isExternal ?? false }.count
    
    var mediaStreams = self
    
    switch streamType {
    case .direct:
        for (index, mediaStream) in mediaStreams.enumerated() {
            var updatedStream = mediaStream
            if updatedStream.isExternal ?? false {
                updatedStream.index = (updatedStream.index ?? 0) + 1 + embeddedSubtitleCount + audioStreamCount
            } else {
                updatedStream.index = (updatedStream.index ?? 0) + externalSubtitleCount
            }
            mediaStreams[index] = updatedStream
        }
    case .hls:
            *Whatever we need to do to get this to work for HLS?*
    case .transcode:
            *Whatever we need to do to get this to work for transcodes?*
    }
    return mediaStreams
}

As an FYI, for testing you can force transcoding by going to Settings > Playback Quality and either set Device Profile to Most Compatible if your content isn't already H.264 & AAC or you can lower the Maximum Bitrate to something under the bitrate of the original file.

[Gondnat]

I've been screwing around with this for a bit. Does Jellyfin/Swiftfin downsample audio? I think our Transcode Subtitle Index is getting thrown off because the audio index is unreliable. It looks like the Audio selection also gets screwed up by being transcoded but it seems to be more likely to get screwed up with multiple audio/subtitle sources.

From testing, this PR seems to work very consistently with non-transcoded content. IMO, maybe we pas in the StreamType as a parameter then have this run for DirectPlay. Figuring out transcoded should still be part of the solution but this would be my take on this:

func adjustExternalSubtitleIndexes(streamType: StreamType, audioStreamCount: Int) -> [MediaStream] {
    guard allSatisfy({ $0.type == .subtitle }) else { return self }
    
    let embeddedSubtitleCount = filter { !($0.isExternal ?? false) }.count
    let externalSubtitleCount = filter { $0.isExternal ?? false }.count
    
    var mediaStreams = self
    
    switch streamType {
    case .direct:
        for (index, mediaStream) in mediaStreams.enumerated() {
            var updatedStream = mediaStream
            if updatedStream.isExternal ?? false {
                updatedStream.index = (updatedStream.index ?? 0) + 1 + embeddedSubtitleCount + audioStreamCount
            } else {
                updatedStream.index = (updatedStream.index ?? 0) + externalSubtitleCount
            }
            mediaStreams[index] = updatedStream
        }
    case .hls:
            *Whatever we need to do to get this to work for HLS?*
    case .transcode:
            *Whatever we need to do to get this to work for transcodes?*
    }
    return mediaStreams
}

As an FYI, for testing you can force transcoding by going to Settings > Playback Quality and either set Device Profile to Most Compatible if your content isn't already H.264 & AAC or you can lower the Maximum Bitrate to something under the bitrate of the original file.

Through code review and some testing, I think this issue might be related to VLCKit.
VLCKit behaves differently in handling the order of subtitles, even when they are added in the same sequence using addPlaybackSlave. For non-transcoded content, external subtitles appear after embedded subtitles. However, with transcoded content, the external subtitles take precedence.
Still working on it.