Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iOS] Admin Dashboard - Migrate to Own Coordinator/Folder #1300

Merged
merged 3 commits into from
Nov 4, 2024

Conversation

JPKribs
Copy link
Member

@JPKribs JPKribs commented Oct 31, 2024

This looks a lot bigger than it is...

Summary

This does the follow tasks:

  1. Rename all instances of UserDashboard to AdminDashboard
  2. Move all AdminDashboard items into their own folder (No longer inside the SettingsView folder)
  3. Create an AdminDashboardCoordinator and move all coordinator AdminDashboard items from the SettingsCoordinator
  4. Ensure that all AdminDashboard ViewModels are in the iOS Target Build only
  5. Add the following to the AdminDashboardView to better mirror the SettingsView:
        .navigationBarTitleDisplayMode(.inline)
        .navigationBarCloseButton {
            router.dismissCoordinator()
        }

I also added all the AdminDashboard ViewModels to a single folder to clean up the ViewModels folder a little bit. Everything is tested and working as expected. Functionally, the only difference is the AdminDashboard is a Modal instead of a Push.

JPKribs and others added 3 commits October 31, 2024 17:05
…ingly since this is an admin only function. Move all AdminDashboard items from SettingsCoordinator to their own AdminDashboardCoordinator. Move all ViewModels to ONLY live inside of the iOS build since tvOS is
Copy link
Member

@LePips LePips left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for doing this! I only changed it back to a push instead of a modal.

@JPKribs
Copy link
Member Author

JPKribs commented Nov 4, 2024

Thank you for doing this! I only changed it back to a push instead of a modal.

My only reason for that was so I could init from here. But, I realized that would be called from a totally different coordinator (HomeCoordinator) so push completely works here!

@LePips LePips merged commit bcc1b6e into jellyfin:main Nov 4, 2024
4 checks passed
@JPKribs JPKribs deleted the AdminDashboardCoordinator branch November 5, 2024 05:09
@JPKribs JPKribs added enhancement New feature or request developer Developer facing issues labels Jan 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
developer Developer facing issues enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants