[iOS & tvOS] Generic Button to Input from an Alert #1273
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this is my most re-used component that I was using in #1271 so I thought it made sense to make sure this was done right before I threw this into 20 places.
The goal is to create a generic 'Chevron Button' that displays a value but, when selected, presents an input in an alert. Instead of mandating an input type, I have a trailing 'menu' input option that allows any view to be used as the input type.
Finally, I added some optional logic so this can be Init with strings or text, then the same options with onSave and onCancel logic so this can be used to input values and have those values not take effect until saved.
I wanted to split this out from any real logic changes since I intend on inputting values like this in a few different places so I wanted to be sure this was solid before ended up in a few different locations. For this PR, this is only replacing the maxNextUp input logic in SettingsView > CustomizeViewSettings > Components > HomeSection.
This logic is identical in iOS and tvOS.