Various AniList Improvements & Bugfixes #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…a, Improve code styling
Musi13
changed the title
|
Closed and reopened because I hit create before I was done editing 😅 |
Musi13
commented
May 17, 2020
| @@ -16,7 +16,7 @@ namespace Jellyfin.Plugin.Anime.Providers.AniList | |||
| /// Based on the new API from AniList | |||
| /// 🛈 This code works with the API Interface (v2) from AniList | |||
| /// 🛈 https://anilist.gitbooks.io/anilist-apiv2-docs | |||
| /// 🛈 THIS IS AN UNOFFICAL API INTERFACE FOR EMBY | |||
| /// 🛈 THIS IS AN UNOFFICAL API INTERFACE FOR JELLYFIN | |||
There was a problem hiding this comment.
Summary of changes in this file:
- Fixed indentation (mostly in graphql)
- Moved some functions to be methods of the Media object
- Add more attributes to graphql call
- Update comments
Musi13
commented
May 17, 2020
| @@ -0,0 +1,107 @@ | |||
| using System; | |||
There was a problem hiding this comment.
This file is basically a copy of SeriesProvider with sed s/Series/Movie/
Musi13
commented
May 17, 2020
| @@ -1,6 +1,12 @@ | |||
| using System; | |||
There was a problem hiding this comment.
Most of this file is serialization setup for the JSON parser, attributes come from the AniList API Docs and mostly the API v2 GraphQL Docs. There's also methods added to convert values from AniList's representation to Jellyfin's.
The idea is you use Media/MediaSearchResult internally (to the plugin) and convert it to the relevant Jellyfin object type through ToMovie and ToSeries, that way both providers can share most of the code.
crobibero
approved these changes
Jul 19, 2020
Co-authored-by: Bond-009 <[email protected]>
oddstr13
approved these changes
Jul 19, 2020
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a few improvements to the AniList providers:
Screenshots