-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow AniDB as an agent for movies #53
Conversation
Are movies and shows treated the same on AniDB? |
Yes, on AniDB movies are just shows with one episode. Occasionally, there's a few more "episodes" for when a movie may be split into multiple parts, but that's the general rule. Here's an example: https://anidb.net/anime/28#Episodes |
Jellyfin.Plugin.Anime/Providers/AniDB/Metadata/AniDbMovieImageProvider.cs
Outdated
Show resolved
Hide resolved
Jellyfin.Plugin.Anime/Providers/AniDB/Metadata/AniDbMovieImageProvider.cs
Outdated
Show resolved
Hide resolved
Jellyfin.Plugin.Anime/Providers/AniDB/Metadata/AniDbMovieProvider.cs
Outdated
Show resolved
Hide resolved
Jellyfin.Plugin.Anime/Providers/AniDB/Metadata/AniDbMovieImageProvider.cs
Outdated
Show resolved
Hide resolved
… commented EpisodeProvider code
I think I've addressed your comments. The AniDbMovieImageProvider class was just copied from the existing AniDbSeasonImageProvider class, so I didn't look at formatting. I've reworded the summary to be a bit more clear, and changed some of the methods to more directly call the SeriesImageProvider counterparts. |
Jellyfin.Plugin.Anime/Providers/AniDB/Metadata/AniDbMovieImageProvider.cs
Outdated
Show resolved
Hide resolved
…, because they currently do the same thing
I also have some changes to fix/improve searching (i.e. fix #50 and add images to search results). I thought I would make another PR after this is merged since those changes are unrelated, but that would mean revving the version twice. Is that okay, or should I add them here so everything goes in as 5.0.0? |
I would revert the version bump in this one and we can merge it soon, then bump the version in your next pull request. |
Alright, I've removed the version bump from this PR and added it to a new branch. I can't PR that yet because it depends on the ImageProvider class in this one. But once this is in, I'll open the other PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
This PR adds an AniDBMovieProvider class that allows anime to be included in
Movie
type libraries. Internally, it proxies all lookups to the existing Series provider.Screenshots