Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow AniDB as an agent for movies #53

Merged
merged 5 commits into from
Mar 9, 2020
Merged

Allow AniDB as an agent for movies #53

merged 5 commits into from
Mar 9, 2020

Conversation

Musi13
Copy link
Contributor

@Musi13 Musi13 commented Mar 8, 2020

This PR adds an AniDBMovieProvider class that allows anime to be included in Movie type libraries. Internally, it proxies all lookups to the existing Series provider.

Screenshots

anime-movies-1
anime-movies-2

@dkanada
Copy link
Member

dkanada commented Mar 8, 2020

Are movies and shows treated the same on AniDB?

@Musi13
Copy link
Contributor Author

Musi13 commented Mar 8, 2020

Yes, on AniDB movies are just shows with one episode. Occasionally, there's a few more "episodes" for when a movie may be split into multiple parts, but that's the general rule.

Here's an example: https://anidb.net/anime/28#Episodes

@Musi13
Copy link
Contributor Author

Musi13 commented Mar 8, 2020

I think I've addressed your comments. The AniDbMovieImageProvider class was just copied from the existing AniDbSeasonImageProvider class, so I didn't look at formatting.

I've reworded the summary to be a bit more clear, and changed some of the methods to more directly call the SeriesImageProvider counterparts.

@Musi13
Copy link
Contributor Author

Musi13 commented Mar 8, 2020

I also have some changes to fix/improve searching (i.e. fix #50 and add images to search results). I thought I would make another PR after this is merged since those changes are unrelated, but that would mean revving the version twice.

Is that okay, or should I add them here so everything goes in as 5.0.0?

@dkanada
Copy link
Member

dkanada commented Mar 9, 2020

I would revert the version bump in this one and we can merge it soon, then bump the version in your next pull request.

@Musi13
Copy link
Contributor Author

Musi13 commented Mar 9, 2020

Alright, I've removed the version bump from this PR and added it to a new branch. I can't PR that yet because it depends on the ImageProvider class in this one. But once this is in, I'll open the other PR.

Copy link
Member

@dkanada dkanada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dkanada dkanada merged commit f1cf9ef into jellyfin-archive:master Mar 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants