Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix script used for Google Analytics #596

Merged
merged 1 commit into from
Dec 24, 2021
Merged

Fix script used for Google Analytics #596

merged 1 commit into from
Dec 24, 2021

Conversation

MasterMedo
Copy link
Contributor

closes #561

A window attribute was missing.

joereddington
joereddington approved these changes Aug 25, 2021
View reviewed changes
Copy link

@joereddington joereddington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've inspected, and I'm happy it's reasonable.

NicorDesigns
NicorDesigns approved these changes Dec 24, 2021
View reviewed changes
Copy link

@NicorDesigns NicorDesigns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://stackoverflow.com/questions/17207458/how-to-add-google-analytics-tracking-id-to-github-pages

@ashmaroli ashmaroli changed the title update google-analytics Fix script used for Google Analytics Dec 24, 2021
@ashmaroli
Copy link
Member

Thanks @MasterMedo
@jekyllbot: merge +fix

@jekyllbot jekyllbot merged commit 8fbcefa into jekyll:master Dec 24, 2021
jekyllbot added a commit that referenced this pull request Dec 24, 2021
@jekyllbot
Update history to reflect merge of #596 [ci skip]
868b90f
@jekyll jekyll locked and limited conversation to collaborators Dec 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ashmaroli ashmaroli ashmaroli approved these changes

@NicorDesigns NicorDesigns NicorDesigns approved these changes

@joereddington joereddington joereddington approved these changes

Assignees
No one assigned
Labels
bug fix frozen-due-to-age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Google Analytics data not received
5 participants
@MasterMedo @ashmaroli @joereddington @NicorDesigns @jekyllbot