Conversation
|
|
||
|
|
||
| class Rectangle: | ||
| def __init__(self, lower_left_corner=Point(0,0), width=0, height=0): |
There was a problem hiding this comment.
E231 missing whitespace after ','
|
|
||
|
|
||
| class Circle: | ||
| def __init__(self, center=Point(0,0), radius=0): |
There was a problem hiding this comment.
E231 missing whitespace after ','
| return True | ||
|
|
||
| def rect_circle_overlap(self, rectangle): | ||
| points_on_rect= [] |
There was a problem hiding this comment.
E225 missing whitespace around operator
| # We must slice rectangle fair enough to have two points lying on | ||
| # the same side of the rectangle closest to the center of circle | ||
| width_points = floor(20 * rectangle.width | ||
| / (rectangle.height + rectangle.width) |
There was a problem hiding this comment.
W503 line break before binary operator
| # the same side of the rectangle closest to the center of circle | ||
| width_points = floor(20 * rectangle.width | ||
| / (rectangle.height + rectangle.width) | ||
| + 1) |
There was a problem hiding this comment.
W503 line break before binary operator
| assert rect_in_circle(circle, test_input) == expected | ||
|
|
||
|
|
||
| @pytest.mark.parametrize("test_input, expected", [ |
There was a problem hiding this comment.
F811 redefinition of unused 'test_eval' from line 24
| self.weight = weight | ||
| self.sugar = sugar | ||
|
|
||
| class ChocolateBar: |
There was a problem hiding this comment.
E302 expected 2 blank lines, found 1
|
|
||
| return ret | ||
|
|
||
| def main(): |
There was a problem hiding this comment.
E302 expected 2 blank lines, found 1
| print("-----------------------------") | ||
| pprint(inspect_specific_object_attributes(nussbeisser)) | ||
|
|
||
| if __name__ == "__main__": |
There was a problem hiding this comment.
E305 expected 2 blank lines after class or function definition, found 1
| original_nussbeisser = ChocolateBar(Sweet(100, 40.5), 6, ["milk", "nuts"], | ||
| "nutty", 15.7) | ||
| alpengold_nussbeisser = ChocolateBar(Sweet(100, 46.5), 6, ["milk", "nuts"], | ||
| "nutty", 14.5) |
There was a problem hiding this comment.
E128 continuation line under-indented for visual indent
3tom
force-pushed
the
tomekDiakowTieto/lesson_13_objects_and_classes
branch
from
957449c to
f67ce2c
Compare
Completed all exercises for lesson 13. Signed-off-by: Tomasz Medrek <tomasz.medrek@tieto.com>
3tom
force-pushed
the
tomekDiakowTieto/lesson_13_objects_and_classes
branch
from
f67ce2c to
7e5bea5
Compare
2 participants
Dear @tomekDiakowTieto ,
Please take a look.
Thanks in advance,
Tomasz