Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove example application causing dependency management headaches #29

Merged
merged 2 commits into from
Dec 17, 2024

Conversation

sdassow
Copy link
Contributor

@sdassow sdassow commented Dec 16, 2024

It happened in the past that the Fyne project had to deal with circular dependency/versioning issues, and when trying to update go-locale to get the latest fixes it happened again, which made me investigate...

Having a Fyne example application as part of go-locale leads to a (circular) dependency chain that is conceptually calling for trouble, and I would like to suggest solving this by removing examples/golocale-gui/ and updating go.{mod,sum} accordingly.

Since go-locale is integrated in Fyne anyways, do we still need this example?

@sdassow sdassow changed the title Remove example application that causing is dependency management headaches Remove example application causing dependency management headaches Dec 16, 2024
@jeandeaual
Copy link
Owner

This example was mostly used to show how to use the library with Fyne.
Since, as you pointed out, Fyne now integrates this library directly, I’m fine to have it removed if it helps fix circular dependency issues and reduce the number of dependencies of this project.

I do have one small request: could you please also remove the reference to this example from README.md?

@jeandeaual
Copy link
Owner

Great, thank you!

@jeandeaual jeandeaual merged commit fcc2cad into jeandeaual:master Dec 17, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants