Fixes for Python3, switched to pcryptodome#28
Open
BenWoodford wants to merge 118 commits intojdhorne:masterfrom
Open
Fixes for Python3, switched to pcryptodome#28BenWoodford wants to merge 118 commits intojdhorne:masterfrom
BenWoodford wants to merge 118 commits intojdhorne:masterfrom
Conversation
|
Thanks @BenWoodford, fine by me. 👍 |
|
I like it. Thanks @BenWoodford |
In case of a long time since requesting an update from the car the Nissan servers return just `{ "status": 200 }`. Fix to avoid crash in this
instance.
Author
|
Pinging @jdhorne as I don't think PRs fire a Github notification |
6 tasks
Owner
|
Hi @BenWoodford; does this break compatibility with Python 2? I know some folks are still using that. Just want to make sure I know what I'm doing by approving. |
Author
|
Honestly? No idea. I wasn't aware people were even actively using Python 2 for new projects. I would assume so. This is mostly to fix stuff like tabs being used instead of spaces, etc. However I don't know if |
Fix 25 July API changes.
Updated travellist to response
Version 2.10
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
13 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This includes numerous fixes for Python3 from @tomhillable and @filcole, which I've merged (sometimes manually...) into my own fork - but I feel like I should PR them. I hope the others don't mind, but right now this lib doesn't actually work with later versions of Python.