Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor patches for review process #257

Merged
merged 7 commits into from
Apr 19, 2024

Conversation

briangann
Copy link
Contributor

Hello,

Here are a couple of changes for the review process.

These change are to remove the console output and adding some badges for build status and marketplace links.

I've added a scaled image of the logo that will render better inside Grafana when browsing the catalog.

If want to merge this (or make similar changes) and resubmit a new build we'll be able to get it reviewed/published quickly.

Thanks!

Brian

@briangann
Copy link
Contributor Author

briangann commented Apr 9, 2024

Just a quick update, I updated the workflows to use yarn v1, and fixed some dependency issues.

The levitate workflow is expected to fail here because there are a number of deprecated calls being used (it is comparing against v10.4.1)

If you need any help feel free to ping me on slack!

I'm going to check the migration handler also to see if there is anything needed there, moving from angular to react usually requires some migrations of the config sections.

@xaner4
Copy link
Contributor

xaner4 commented Apr 18, 2024

Any plans on getting this merged soon @jdbranham?

@jdbranham jdbranham merged commit 9f14362 into jdbranham:master Apr 19, 2024
1 of 2 checks passed
@jdbranham
Copy link
Owner

@briangann - thanks so much for handling these updates. 🎉
I'd seen your message and meant to check this out a while back 😬

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants