Upgrade molecule to v2 #101
Conversation
Set changed_when to false for installing Python3 on the Docker machine. Remove unused code from Molecule v1. Update TravisCI for Molecule v2. Use the file module rather than the copy module to create the logfile.
YPCrumble
force-pushed
the
upgrade_molecule
branch
from
4357497 to
413c0df
Compare
|
@jcalazan pinging on this PR - it's still passing my forked Travis test suite and I'd love to get it merged in before creating another PR for #66. If it would be helpful and you'd be willing to provide write access to the repo, I'd love to help with reviewing and merging some of the open PR's as well. |
|
@jcalazan - any chance of getting this approved/merged? It's a pretty excellent (and overdue) change. I second a request to grant @YPCrumble write access to this repo. They've been doing some fantastic work, and I'd love to see this repo get some more active development! |
|
@YPCrumble Really sorry I've been MIA for a very long time! I was actually gonna ask you if you want to b e a maintainer as I'm currently swamped with other projects. Will give you the access in a bit and thanks again for all the contributions! |
|
Thanks @jcalazan ! Will let you know if I have any questions. Merging this in now :). |
Upgrade molecule to v2
This PR fixes #78:
@jcalazan I'd recommend pulling this in first and then rerunning tests for other PR's.
Also fixes #97 (I'll close the other PR).