fix: add exception message to warning when running info#2247
Open
quintesse wants to merge 2 commits intojbangdev:mainfrom
Open
fix: add exception message to warning when running info#2247quintesse wants to merge 2 commits intojbangdev:mainfrom
info#2247quintesse wants to merge 2 commits intojbangdev:mainfrom
Conversation
Collaborator
|
its useful for humans - but I think we'll want to add something more structured into the json output that tools can just show possibly even try provide fixes for it. |
Collaborator
|
am I missing something here or are you assuming there will only ever be one error during jbang info gathering? isn't there option of mulitiple errror places? |
Contributor
Author
See my comment here #2240 (comment) |
maxandersen
reviewed
Oct 21, 2025
| String gav; | ||
| String module; | ||
| Map<String, List<ProjectFile>> docs; | ||
| String error; |
Collaborator
There was a problem hiding this comment.
I know we don't have multiple errors at this moment but I do think we will so how about we make this one an array/list and ensure we dont break parsing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2240