fix: Put marker file into .tmp directory#22
Open
koppor wants to merge 2 commits intojbangdev:mainfrom
Open
Conversation
koppor
changed the title
Contributor
Author
|
@aalmiray May I ask for a comment? I worked the whole day on the build again and saw this message in the output. |
aalmiray
requested changes
Feb 23, 2026
| boolean printBanner = null == System.getProperty(ORG_KORDAMP_BANNER) || Boolean.getBoolean(ORG_KORDAMP_BANNER) | ||
|
|
||
| File parent = new File(gradle.gradleUserHomeDir, 'caches') | ||
| File parent = new File(gradle.gradleUserHomeDir, '.tmp') |
Contributor
There was a problem hiding this comment.
Just use the gradleUserHomeDir directly, do not specify a child directory.
koppor
commented
Feb 23, 2026
Contributor
|
The build is currently failing. You didn't run a local build, did you? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When running the plugin, I get following output
The claim is true - the file seems to be modified on each run.
Proposal: Treat the file as temporary file - in most cases, this will lead to the same results.
(Side track: We are using the release build, but still
-SNAPSHOTis output. Not sure why)