Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: delete all requests using raw_delete to avoid memory issues #770

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

moonsikpark
Copy link

No description provided.

Copy link

codecov bot commented Jan 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.24%. Comparing base (1cb4623) to head (8fbb4e9).
Report is 44 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #770      +/-   ##
==========================================
+ Coverage   86.76%   87.24%   +0.48%     
==========================================
  Files          52       52              
  Lines        2115     2141      +26     
==========================================
+ Hits         1835     1868      +33     
+ Misses        280      273       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@albertyw
Copy link
Member

Is this safe from side effects? According to documentation, _raw_delete doesn't support signals and has no protection for cascades. Django-silk doesn't utilize signals (users of django-silk might, though unlikely) but there are many objects that do use cascade (Response, SQLQuery, and BaseProfile).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants