Use python3 syntax for super() #374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM, might be a good opportunity to adapt all the super calls at once? |
I don't believe there are any more super calls? A quick search only shows up this one. |
I didn’t check so if there aren’t any other we should be good to go 😁 @giovannicimolin I will let you deal with the merge etc |
giovannicimolin
approved these changes
Jan 21, 2025
|
Great, this is probably the fastest I've seen a PR get merged lol. Thanks 🙌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Came across this while trying to set the framework up.
Not sure why but the given python2 syntax seems to error for my project citing
'super' object has no attribute 'post', migrating this to the python3 syntax seems to fix it.