Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add distinct on support #104

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

delta575
Copy link

@delta575 delta575 commented Jul 2, 2022

Subject: add distinct on support

Feature or Bugfix

  • Feature

Purpose

  • Add support for distinct on behavior

Detail

  • Use ROW_NUMBER() OVER ( PARTITION BY < field >), then select row_number = 1

Relates

@codecov
Copy link

codecov bot commented Jul 4, 2022

Codecov Report

Merging #104 (8d7f03f) into master (57b3d4a) will decrease coverage by 2.56%.
The diff coverage is 57.50%.

❗ Current head 8d7f03f differs from pull request most recent head 35a3861. Consider uploading reports for the commit 35a3861 to get more accurate results

@@            Coverage Diff             @@
##           master     #104      +/-   ##
==========================================
- Coverage   64.00%   61.44%   -2.57%     
==========================================
  Files           4        5       +1     
  Lines         439      555     +116     
  Branches      127      164      +37     
==========================================
+ Hits          281      341      +60     
- Misses        116      158      +42     
- Partials       42       56      +14     
Impacted Files Coverage Δ
django_redshift_backend/compiler.py 52.83% <52.83%> (ø)
django_redshift_backend/base.py 62.67% <92.85%> (-0.56%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 57b3d4a...35a3861. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant