Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bigger decimal fields (20 digits) (hold more currencies) #153

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

devkral
Copy link
Contributor

@devkral devkral commented Oct 7, 2017

8 decimal places to hold smallest btc unit
12 digits to hold cheaper currencies

#9

@codecov-io
Copy link

codecov-io commented Oct 7, 2017

Codecov Report

Merging #153 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #153      +/-   ##
==========================================
+ Coverage   79.13%   79.15%   +0.01%     
==========================================
  Files          27       27              
  Lines        1649     1650       +1     
  Branches      190      190              
==========================================
+ Hits         1305     1306       +1     
  Misses        245      245              
  Partials       99       99
Impacted Files Coverage Δ
payments/models.py 75% <100%> (+0.21%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 49c93aa...a75300c. Read the comment docs.

@devkral devkral changed the title bigger decimal fields (20) (hold more currencies) bigger decimal fields (20 digits) (hold more currencies) Oct 7, 2017
@devkral
Copy link
Contributor Author

devkral commented Oct 9, 2017

I am not sure if this pull request is a good idea. Most people just want two decimal_places and 12 digits.

@devkral
Copy link
Contributor Author

devkral commented Oct 9, 2017

anyway it is very domain specific (if you want to trade bitcoins or not)

@Pacu2
Copy link
Contributor

Pacu2 commented Sep 7, 2018

I think this should be set by a variable as in #188

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants