Alternate provider factory #121
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 78.13% (diff: 28.57%)@@ master #121 diff @@
==========================================
Files 29 29
Lines 1682 1688 +6
Methods 0 0
Messages 0 0
Branches 193 194 +1
==========================================
+ Hits 1318 1319 +1
- Misses 260 264 +4
- Partials 104 105 +1
|
|
This is a feature I really need, any progress on the merge? |
|
No progress here to report. We're thinking about an entirely different API for a future release of django-payments to better support other use cases. |
|
Excellent, though do you have an estimation of the target release date? weeks/months? (to keep track) |
|
I know it's been years, but I'd love to see this happen. Would an updated PR for this be accepted? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch provide an optional alternative to the current core.py/provider_factory method by setting an extra variable in the settings.
You could customize where the PAYMENTS_VARIANTS settings should be (DB instead of settings for exemple); have as many "stripe settings", isolated from one another.
I tried to provide as well a doc with this patch "doc/alternate_provider_factory.rst", it's a draft and unlinked from the other, as-is.
I needed to be able to configure a 'per entity in the DB' PAYMENT_VARIANTS list through the backend of my Django project. This patch helped me resolve this problem.