Add AUDITLOG_TRUNCATE_CHANGES_DISPLAY and AUDITLOG_TRUNCATE_LIMIT #684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hoangquochung1110
force-pushed
the
feature/add-config-for-truncate-changes-display
branch
from
5bdd0da
to
6119547
Compare
hramezani
reviewed
Oct 31, 2024
hramezani
reviewed
Oct 31, 2024
hramezani
reviewed
Oct 31, 2024
|
Thanks @hoangquochung1110 for the PR, I left a couple of comments. Please add a changelog |
To configure how many characters will be truncated or disable it
hoangquochung1110
force-pushed
the
feature/add-config-for-truncate-changes-display
branch
2 times, most recently
from
7343dfe
to
0c5723e
Compare
|
My appreciation to your time and comments |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #684 +/- ##
==========================================
+ Coverage 95.21% 95.48% +0.26%
==========================================
Files 31 32 +1
Lines 1025 1085 +60
==========================================
+ Hits 976 1036 +60
Misses 49 49 ☔ View full report in Codecov by Sentry. |
hramezani
reviewed
Nov 3, 2024
docs/source/usage.rst
Outdated
Comment on lines
310
to
317
| Number of characters at which strings in `changes_display_dict` property should be truncated if length exceeded | ||
|
|
||
| Set to 140 by default. | ||
|
|
||
| You can use this settings to preserve the strings by set it to a negative number. | ||
|
|
There was a problem hiding this comment.
Suggested change
| Number of characters at which strings in `changes_display_dict` property should be truncated if length exceeded | |
| Set to 140 by default. | |
| You can use this settings to preserve the strings by set it to a negative number. | |
| This configuration variable defines the truncation behavior for strings in `changes_display_dict`, with a default value of `140` characters. | |
| 0: The entire string is truncated, resulting in an empty output. | |
| Positive values (e.g., 5): Truncates the string, keeping only the specified number of characters followed by an ellipsis (...) after the limit. | |
| Negative values: No truncation occurs, and the full string is displayed. | |
| .. versionadded:: 3.1.0 | |
|
Thanks @hoangquochung1110 for the update. LGTM, I only left a suggestion for the new config description. |
to keep or truncate strings of `changes_display_dict` property at a variable length
hoangquochung1110
force-pushed
the
feature/add-config-for-truncate-changes-display
branch
from
0c5723e
to
19000db
Compare
hramezani
approved these changes
Nov 4, 2024
|
Thanks @hoangquochung1110 |
|
Thank you for your approval @hramezani |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To configure how many characters will be truncated or disable it
Resovle #633