Skip to content

Conversation

@LouisJustinTALLOT
Copy link
Contributor

Change the variable $x$ with the correct name $x1$ used in the signature of the function.

@google-cla
Copy link

google-cla bot commented Apr 1, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Copy link
Collaborator

@jakevdp jakevdp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thank you!

@google-ml-butler google-ml-butler bot added kokoro:force-run pull ready Ready for copybara import and testing labels Apr 1, 2025
@jakevdp
Copy link
Collaborator

jakevdp commented Apr 1, 2025

Hi - we've run into some test failures that should be fixed on the main branch. Can you rebase against main and we'll try again? Thanks!

@jakevdp jakevdp self-assigned this Apr 1, 2025
@copybara-service copybara-service bot merged commit 747c580 into jax-ml:main Apr 1, 2025
23 of 25 checks passed
@jakevdp
Copy link
Collaborator

jakevdp commented Apr 1, 2025

Hi - we've run into some test failures that should be fixed on the main branch. Can you rebase against main and we'll try again? Thanks!

Nevermind, looks like we managed to resolve this. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kokoro:force-run pull ready Ready for copybara import and testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants