Merge pull request #443 from dcrescim/read-csv-fix

Fix for readCSV mismatch between Browser and Node
javascriptdata · Apr 20, 2022 · 39c5103 · 39c5103
2 parents 0f85cae + f6afd8d
commit 39c5103
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/src/danfojs-base/io/browser/io.csv.ts b/src/danfojs-base/io/browser/io.csv.ts
@@ -52,6 +52,7 @@ const $readCSV = async (file: any, options?: CsvInputOptionsBrowser): Promise<Da
     Papa.parse(file, {
       header: true,
       dynamicTyping: true,
+      skipEmptyLines: 'greedy',
       ...options,
       download: true,
       complete: results => {

diff --git a/src/danfojs-base/io/node/io.csv.ts b/src/danfojs-base/io/node/io.csv.ts
@@ -55,11 +55,12 @@ const $readCSV = async (filePath: string, options?: CsvInputOptionsNode): Promis
       const optionsWithDefaults = {
         header: true,
         dynamicTyping: true,
+        skipEmptyLines: 'greedy',
         ...options,
       }
 
       const dataStream = request.get(filePath);
-      const parseStream: any = Papa.parse(Papa.NODE_STREAM_INPUT, optionsWithDefaults);
+      const parseStream: any = Papa.parse(Papa.NODE_STREAM_INPUT, optionsWithDefaults as any);
       dataStream.pipe(parseStream);
 
       const data: any = [];