Skip to content

Conversation

@mao-sz
Copy link

@mao-sz mao-sz commented Dec 7, 2025

Given the scope and intent of the array methods lesson and the expected knowledge level of learners going through this lesson, I don't believe the "Shuffle an array" task should instruct to make each permutation of equal probability. Successfully achieving that requires that either someone happens to already know a shuffling algorithm like Fisher-Yates, or understands why nuances with Array.prototype.sort() would lead to permutation bias.

I think it's more pedagogically appropriate to simply omit that requirement from the instructions. That requirement won't likely change much about how many learners would do things, but risks sending someone down a rabbit hole of stuff out of the scope of practising working with arrays and array methods.

The solution can stay as is - the explanation is good and makes sense to introduce the permutation bias concept there, just not as an actual requirement for the task.

In various learning communities I take part in, this is a very common pain point and rabbit hole I see learners go down when trying to solve it (i.e. not a rabbit hole they go down after reading the explanation).

@javascript-translate-bot javascript-translate-bot added the review needed Review needed, please approve or request changes label Dec 7, 2025
@javascript-translate-bot javascript-translate-bot requested review from a team December 7, 2025 17:19
@CLAassistant
Copy link

CLAassistant commented Dec 7, 2025

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

review needed Review needed, please approve or request changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants