fix(nix): no longer trying to access non existent attribute#73
Closed
Libadoxon wants to merge 1 commit intojavalsai:masterfrom
Closed
fix(nix): no longer trying to access non existent attribute#73Libadoxon wants to merge 1 commit intojavalsai:masterfrom
Libadoxon wants to merge 1 commit intojavalsai:masterfrom
Conversation
Author
|
Okay I just took a closer look at the nix code, with your permission I would rewrite the whole thing (mostly). Nothing against your nix skills but there a some serious anti patters and maintainability burdens that can be removed. |
Collaborator
It'd be really neat if you would do that! |
Author
|
Superseded by #74 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes the nix build.
cfg-filedoesn't exist ifget-cfgis null, so checking ifget-cfgis null instead ofcfg-file