Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bugfix] mobile printing #194

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

[bugfix] mobile printing #194

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5927116
[bugfix] enables printing on mobile Chrome
evanb2 Dec 12, 2019
6e88caa
[bugfix] keeps iFrame element until next print
evanb2 Dec 17, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 7 additions & 22 deletions printThis.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,9 @@

var opt;
$.fn.printThis = function(options) {
// removes any previous printThis iFrames
$("iframe[name='printIframe']").remove();

opt = $.extend({}, $.fn.printThis.defaults, options);
var $element = this instanceof jQuery ? this : $(this);

Expand Down Expand Up @@ -275,28 +278,10 @@
attachOnBeforePrintEvent($iframe, opt.beforePrintEvent);

setTimeout(function() {
if ($iframe.hasClass("MSIE")) {
// check if the iframe was created with the ugly hack
// and perform another ugly hack out of neccessity
window.frames["printIframe"].focus();
$head.append("<script> window.print(); </s" + "cript>");
} else {
// proper method
if (document.queryCommandSupported("print")) {
$iframe[0].contentWindow.document.execCommand("print", false, null);
} else {
$iframe[0].contentWindow.focus();
$iframe[0].contentWindow.print();
}
}

// remove iframe after print
if (!opt.debug) {
setTimeout(function() {
$iframe.remove();

}, 1000);
}
// check if the iframe was created with the ugly hack
// and perform another ugly hack out of neccessity
window.frames["printIframe"].focus();
$head.append("<script> window.print(); </script>");

// after print callback
if (typeof opt.afterPrint === "function") {
Expand Down