Implement #3332

[xixixao]

I have intentionally split this up into separate commits, the first one is the actual change from Ruby to Node. Having the whole _.template function in Cakefile is not ideal (I cut it down though), but at least doesn't add another dependency. Better solutions welcome.

I've done this after three pints, so peer review would be highly welcomed.

Little note: Highlight.js parses object keys as attribute, so I deleted it from the css file to keep an equivalent style.

Second note: @michaelficarra the run expressions are javascript expressions, so we can't use #{}

[michaelficarra]

Whoops, sorry about that!

[epidemian]

Hehe, i knew you'd probably be working on this. At least i hadn't done much to merge #3198 into master yet 😅

[xixixao]

@epidemian Well, something like that was expected. Let me have a look and merge the two together?

[vendethiel]

The only reason this is hardcoded is because of the web version, right ?

[jashkenas]

Having the whole _.template function in Cakefile is not ideal (I cut it down though), but at least doesn't add another dependency.

Instead of doing that, just put Underscore as a devDependency, like the others — dev dependencies don't really matter.

[xixixao]

@jashkenas I'll use echo as in the mentioned commit, underscore doesn't support CS out of the box. It is quite lightweight in terms of dependencies. The only thing is that npm doesn't install coffee-script to its npm-modules (I assume because we are writing coffee-script), but then Node can't find it. I'll look into it later.

[jashkenas]

Oh, you mean eco? Sure, that's fine too.

The only thing is that npm doesn't install coffee-script to its npm-modules (I assume because we are writing coffee-script), but then Node can't find it.

We can probably assume that you have a version of coffee exposed globally if you're going ahead and rebuilding the docs, so this should be fine.

[xixixao]

eco kinda sucks, but oh well... sstephenson/eco#41

[michaelficarra]

I'd prefer to stay away from a dependency on eco if at all possible. We don't want to ditch one dead technology in favour of another dead technology.

[bjmiller]

I vote for keeping it simple. Failing that, if you're not going to do it with underscore templates, then your best bet is probably ECT. CoffeeKup would be awesome, but it's also not getting much maintenance love.

[vendethiel]

Eco is dead (last commit 2 years ago), EJS is dead (last commit in 2009), damn.
I guess there's toffee that's maintained ... But really, it doesn't matter

[xixixao]

@michaelficarra I'd say this is harmless, eco will work as long as npm keeps its version in the registry. Worse thing is: npm/npm#1341, so you have to manually run npm install inside eco's directory. Global install doesn't help.

[xixixao]

@Nami-Doc ok, I'll try toffee, at least it's got multiline code blocks. Everything's gonna have the npm install problem though.

[bjmiller]

Spent a few minutes fork-jumping. Looks like this is under current maintenance: https://github.com/goodeggs/teacup

[jashkenas]

ok, I'll try toffee, at least it's got multiline code blocks.

Or, instead, you could just stick to Underscore templates (which are about the simplest possible thing for this use case). Having a few lines of JavaScript instead of CoffeeScript at the top of the file is no big deal. And/or you can pull more of the data configuration over into the Cakefile.

[vendethiel]

Yeah, seems like my last edit was not submitted. Let's just use the simplest option, underscore templates

[xixixao]

Underscore it is, toffee is troublesome, codeFor will go to Cakefile and codeFor calls with be in JS.

• turns out my original wasn't such a bad solution

[xixixao]

Done?

[epidemian]

LGTM 👍

[jashkenas]

Almost there. Maybe only require highlightJS when you're going to run the doc:site task?

[xixixao]

@jashkenas Done

[tiye]

@Nami-Doc I thought last commit of ejs is "2 months ago"?
https://github.com/visionmedia/ejs/commits/master

[vendethiel]

@jiyinyiyong oh right, googling it got me on [http://embeddedjs.com/](this website)