compress-gzip - fix: set any value before getting value

packages/compress-brotli/src/index.ts

@@ -15,17 +15,25 @@ export class KeyvBrotli {
 		return this.brotli.compress(value, options);
 	}
 
-	async decompress<T>(data: InputType, options?: BrotliOptions): Promise<T> {
-		return await this.brotli.decompress(data, options) as T;
+	async decompress<T>(data?: InputType, options?: BrotliOptions): Promise<T> {
+		if (data) {
+			return await this.brotli.decompress(data, options) as T;
+		}
+
+		return undefined as unknown as T;
 	}
 
 	async serialize({value, expires}: Serialize): Promise<SerializeResult> {
 		return defaultSerialize({value: await this.compress(value), expires});
 	}
 
-	async deserialize(data: CompressResult): Promise<Serialize> {
-		const {value, expires}: Serialize = defaultDeserialize(data);
-		return {value: await this.decompress(value), expires};
+	async deserialize(data?: CompressResult): Promise<Serialize> {
+		if (data) {
+			const {value, expires}: Serialize = defaultDeserialize(data);
+			return {value: await this.decompress(value), expires};
+		}
+
+		return {value: undefined, expires: undefined};
 	}
 }
 

packages/compress-brotli/src/types.ts

@@ -10,7 +10,7 @@ type BrotliSerialize<T> = (source: InputType) => T;
 type BrotliDeserialize<T> = (source: CompressResult) => T;
 
 export type Serialize = {
-	value: InputType;
+	value?: InputType;
 	expires?: number;
 };
 

packages/compress-brotli/test/test.ts

@@ -102,3 +102,14 @@ test.it('decompression using number array with v8', async t => {
 	t.expect(decompressed).toEqual({help: [1, 2, 4]});
 });
 
+test.it('decompress should not throw error when empty with brotli', async t => {
+	const keyv = new KeyvBrotli();
+	await t.expect(keyv.decompress()).resolves.not.toThrowError();
+});
+
+test.it('should return empty object when empty', async t => {
+	const keyv = new KeyvBrotli();
+	const result = await keyv.deserialize();
+	t.expect(result).toEqual({value: undefined, expires: undefined});
+});
+

packages/compress-gzip/src/index.ts

@@ -1,4 +1,4 @@
-import pako from 'pako';
+import {inflate, deflate} from 'pako';
 import {defaultSerialize, defaultDeserialize} from '@keyv/serialize';
 import type {Options, Serialize} from './types.js';
 
@@ -12,24 +12,28 @@ export class KeyvGzip {
 	}
 
 	async compress(value: pako.Data | string, options?: Options) {
-		return pako.deflate(value, options || this.opts);
+		return deflate(value, options || this.opts);
 	}
 
 	async decompress(value: pako.Data, options?: Options) {
 		if (options) {
 			options.to = 'string';
 		}
 
-		return pako.inflate(value, options || this.opts);
+		return inflate(value, options || this.opts);
 	}
 
 	async serialize({value, expires}: Serialize) {
 		return defaultSerialize({value: await this.compress(value), expires});
 	}
 
 	async deserialize(data: string) {
-		const {value, expires}: Serialize = defaultDeserialize(data);
-		return {value: await this.decompress(value as pako.Data), expires};
+		if (data) {
+			const {value, expires}: Serialize = defaultDeserialize(data);
+			return {value: await this.decompress(value as pako.Data), expires};
+		}
+
+		return {value: undefined, expires: undefined};
 	}
 }
 

packages/compress-gzip/test/test.ts

@@ -1,5 +1,6 @@
 import * as test from 'vitest';
 import {keyvCompresstionTests} from '@keyv/test-suite';
+import {Keyv} from 'keyv';
 import KeyvGzip from '../src/index.js';
 
 // @ts-expect-error - KeyvGzip type
@@ -48,3 +49,13 @@ test.it('decompression with decompression options', async t => {
 	const decompressed = await keyv.decompress(compressed, options);
 	t.expect(decompressed).toBe('whatever');
 });
+
+test.it('decompress should not throw error when empty with gzip', async t => {
+	const keyv = new Keyv({store: new Map(), compression: new KeyvGzip()});
+	await t.expect(keyv.get('foo')).resolves.not.toThrowError();
+});
+
+test.it('should not throw error when empty', async t => {
+	const keyv = new Keyv({store: new Map()});
+	await t.expect(keyv.get('foo')).resolves.not.toThrowError();
+});