Update to React 16.3 (context) #9
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JulienMalige
force-pushed
the
update-react-context
branch
from
7992bf5
to
cb25908
Compare
|
Using this code in our projet (as component, not as library) it works. |
jaredpalmer
approved these changes
Nov 22, 2018
|
Sooo, why this hasn't been merged yet? :) |
|
@JulienMalige Oh, the test is failing because it's trying to run |
|
Any updates? |
|
@imamatory Given that Formik is getting rewritten to Hooks, I don't think this PR is relevant anymore. Or at least that functionality of this package will be included in core Formik. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @jaredpalmer,
I'm trying to update formik-effect to use it with the new Context API (fix #3 #4 #6).
The code looks ok for me, but the Formik prop of the Effect consumer is always empty.
Is my code not correct ?